wasi: clean up core platform abstractions#12503
Open
DePasqualeOrg wants to merge 7 commits into
Open
Conversation
Contributor
|
closes #12427 |
|
GNU testsuite comparison: |
sylvestre
reviewed
May 28, 2026
| pub type Pid = u64; | ||
|
|
||
| #[cfg(target_os = "wasi")] | ||
| #[allow(dead_code)] |
Contributor
There was a problem hiding this comment.
please refactor to avoid the allow dead code
Contributor
Author
There was a problem hiding this comment.
Okay, I think we can just remove ProcessChecker for WASI. Since the original PR is from a couple months ago, I don't remember why exactly it was added.
Merging this PR will not alter performance
Comparing 
Footnotes
|
The command fails during argument validation before reading stdin, so remove unnecessary piped input that could hit EPIPE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first PR split out from the larger WASI changes in #11712.
Changes
rustix::fs::Statfor WASIFileInformationso same-file checks use device/inode identity instead of a file-type/size heuristic.read_fs_list()returnUResult<Vec<MountInfo>>on WASI, matching other platforms while still returning an empty mount list.OsStrExt/OsStringExtimports inenv.tailprocess-check stubs so the shared follow code compiles while--pidremains unsupported.OwnedFileDescriptorOrHandle::into_stdio().